From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Date: Wed, 08 Nov 2006 09:56:18 +0000 Subject: Re: [PATCH 0/1] mspec driver: compile error Message-Id: <20061108015618.571242fb.akpm@osdl.org> List-Id: References: <1162881017.13700.105.camel@sebastian.intellilink.co.jp> <4550609A.7010908@sgi.com> <20061107133512.a49b11e0.akpm@osdl.org> <1162977589.7805.77.camel@sebastian.intellilink.co.jp> <4551A66A.2070506@sgi.com> <1162979130.7805.80.camel@sebastian.intellilink.co.jp> In-Reply-To: <1162979130.7805.80.camel@sebastian.intellilink.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Fernando Luis =?ISO-8859-1?B?VuF6cXVleg==?= Cao Cc: Jes Sorensen , Linux Kernel Mailing List , bjorn_helgaas@hp.com, Nick Piggin , Robin Holt , Dean Nelson , Hugh Dickins , Linus Torvalds , linux-ia64 , Tony Luck On Wed, 08 Nov 2006 18:45:30 +0900 Fernando Luis V=E1zquez Cao wrote: > On Wed, 2006-11-08 at 10:42 +0100, Jes Sorensen wrote: > > Fernando Luis V=E1zquez Cao wrote: > > > On Tue, 2006-11-07 at 13:35 -0800, Andrew Morton wrote: > > > The problem occurs because i386 (as expected) does not define > > > IA64_UNCACHED_ALLOCATOR. I thought that making the select expression > > > depend on IA64 as shown below might silence allmodconfig: > > >=20 > > > select IA64_UNCACHED_ALLOCATOR if IA64 > > >=20 > > > But my guess was wrong and the same warning appeared. It seems that "= if" > > > expressions do not prevent allmodconfig from checking the symbol > > > indicated by the select the "if" is conditioning. By the way, is this > > > the expected behaviour? If so, we need to get rid of the reverse > > > dependency, modify the "depends on" line accordingly, and make > > > IA64_UNCACHED_ALLOCATOR selectable. I may be missing the whole point = so > > > please correct if I am wrong. > >=20 > > This patch is a bad solution as it requires people to manually select > > the uncached allocator. It should be enabled automatically by MSPEC, > > not the other way round. > >=20 > > Given that MSPEC is clearly marked as depending on IA64, it seems bogus > > for i386 allmodconfig to barf over it and the problem should be fixed > > there instead IMHO. > Agreed. That is why I asked if that was allmodconfig's expected > behaviour. Andrew? >=20 kconfig's `select' isn't very smart. This is one of the reasons why one should avoid using it.