From: Stephane Eranian <eranian@hpl.hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] fix uninitialized string in get_model_name()
Date: Fri, 01 Dec 2006 20:45:32 +0000 [thread overview]
Message-ID: <20061201204532.GA709@frankl.hpl.hp.com> (raw)
In-Reply-To: <20061201163035.GE31914@frankl.hpl.hp.com>
On Fri, Dec 01, 2006 at 09:15:05AM -0800, Luck, Tony wrote:
> > If ia64_pal_get_brand_info() fails in get_model_name() we may be copying
> > an invalid string.
>
> I'm not sure I see how. If ia64_pal_get_brand_info() succeeds, it returns
> 0, and must have copied a brand string to brand[]. If it fails (returns non-zero)
> we look family and model and fill in brand[] with something.
>
Ah, yes, now I see that my logic was wrong on the return value of
ia64_pal_get_brand_info(), so I think the code is fine.
>
> Ahh ... do you have a Montecito with some pre-production PAL that
> doesn't implement PAL_GET_BRAND_INFO? That could mess up as we
> don't cover family = 0x20 inside the 'if' statement (as I thought
> that this PAL call was implemented early enough in Montecito that
> everyone would have it).
This can be a problem.
--
-Stephane
prev parent reply other threads:[~2006-12-01 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 16:30 [PATCH] fix uninitialized string in get_model_name() Stephane Eranian
2006-12-01 17:15 ` Luck, Tony
2006-12-01 20:45 ` Stephane Eranian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061201204532.GA709@frankl.hpl.hp.com \
--to=eranian@hpl.hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox