From mboxrd@z Thu Jan 1 00:00:00 1970 From: Horms Date: Fri, 02 Feb 2007 03:57:15 +0000 Subject: Re: [Fastboot] [PATCH] kexec: Fix CONFIG_SMP=n compilation (ia64) Message-Id: <20070202035714.GE16554@verge.net.au> List-Id: References: <10EA09EFD8728347A513008B6B0DA77A086BD0@pdsmsx411.ccr.corp.intel.com> In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A086BD0@pdsmsx411.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Zou, Nanhai" Cc: Magnus Damm , Andrew Morton , Magnus Damm , "Luck, Tony" , linux-ia64@vger.kernel.org, fastboot@lists.osdl.org, linux-kernel@vger.kernel.org On Fri, Feb 02, 2007 at 11:01:21AM +0800, Zou, Nanhai wrote: > > > > void > > > > machine_crash_shutdown(struct pt_regs *pt) > > > > @@ -132,11 +134,12 @@ kdump_cpu_freeze(struct unw_frame_info * > > > > atomic_inc(&kdump_cpu_freezed); > > > > kdump_status[cpuid] = 1; > > > > mb(); > > > > - if (cpuid = 0) { > > > > - for (;;) > > > > - cpu_relax(); > > > > - } else > > > > +#ifdef CONFIG_HOTPLUG_CPU > > > > + if (cpuid != 0) > > > > ia64_jump_to_sal(&sal_boot_rendez_state[cpuid]); > > > > +#endif > > > > + for (;;) > > > > + cpu_relax(); > > > > } > > > > > > I trust ia64_jump_to_sal doesn't return. > > > > So do I. The main problem with the compilation seems to be that > > ia64_jump_to_sal() only exists if CONFIG_HOTPLUG_CPU=y. > > (include/asm-ia64/sal.h, arch/ia64/kernel/head.S) > > > This may cause problem on SN platform. > I remember SN requires cpu0 return to SAL rendez loop to do IRQ redirection. > However this needs SGI people to confirm... Does this mean that CONFIG_HOTPLUG_CPU may be required for kdump on the SN platform? -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/