From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Date: Thu, 08 Feb 2007 03:27:35 +0000 Subject: Re: [PATCH] [IA64] Include kexec.h in arch/ia64/kernel/process.c Message-Id: <20070207192735.2d06e984.randy.dunlap@oracle.com> List-Id: References: <20070207064935.GB726@verge.net.au> <617E1C2C70743745A92448908E030B2A0117C67C@scsmsx411.amr.corp.intel.com> <20070208021900.GB17585@verge.net.au> In-Reply-To: <20070208021900.GB17585@verge.net.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Horms Cc: "Luck, Tony" , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, fastboot@lists.osdl.org, "Zou, Nanhai" , Khalid Aziz , Adrian Bunk , Andrew Morton , Magnus Damm On Thu, 8 Feb 2007 11:19:03 +0900 Horms wrote: > On Wed, Feb 07, 2007 at 09:07:40AM -0800, Luck, Tony wrote: > > > kexec.h is needed by arch/ia64/kernel/process.c so for the > > > declaration of kexec_disable_iosapic() which is used in > > > machine_shutdown(). > > > > > +#include > > > > I merged this into your earlier change (moving machine_shutdown() into > > process.c). Linus pulled it last night. > > Thanks > > > I also added a "#ifdef CONFIG_KEXEC" around the call to > > kexec_disable_iosapic() (because I first noticed that this was > > undefined when building non-KEXEC kernels). But perhaps it might have > > been better to #define an empty stub for this function inside kexec.h > > for the #ifndef CONFIG_KEXEC case? > > Good catch :) uh, every one of Andrew's commit emails now contains the line at the end of my mail sig... Try it sometimes^W often. > I think that #define in the process.c vs an empty stub inside > asm/kexec.h is really a style issue. I'm quite ok with things > the way they are. But If you are more comfortable with the stub > approach, I have no objections. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***