From: Bernhard Walle <bwalle@novell.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Fastboot] Zero size /proc/vmcore on ia64
Date: Wed, 14 Feb 2007 19:59:44 +0000 [thread overview]
Message-ID: <20070214195944.GA18114@strauss.suse.de> (raw)
In-Reply-To: <20070212185756.GA22524@strauss.suse.de>
* Horms <horms@verge.net.au> [2007-02-14 02:38]:
> On Tue, Feb 13, 2007 at 06:03:20PM +0100, Bernhard Walle wrote:
> > > Index: kexec-tools-bw/kexec/arch/ia64/crashdump-ia64.c
> > > =================================> > > --- kexec-tools-bw.orig/kexec/arch/ia64/crashdump-ia64.c 2007-02-13 17:39:18.000000000 +0900
> > > +++ kexec-tools-bw/kexec/arch/ia64/crashdump-ia64.c 2007-02-13 18:09:44.000000000 +0900
> > > @@ -232,13 +232,14 @@
> > > if (crash_create_elf64_headers(info, &elf_info,
> > > crash_memory_range,
> > > nr_ranges,
> > > - &tmp, &sz) < 0)
> > > + &tmp, &sz,
> > > + 4096) < 0)
> >
> > Why not using EFI_PAGE_SIZE here? It would also be good to find a
> > suitable constant name for 1024.
>
> Indeed, I meant to use EFI_PAGE_SIZE instead of 4096.
> I'll fix that up and apply.
>
> As for a good constant name, I'm open to suggestions.
Hmmm ..., I don't know why there must be an alignment to 1024 on i386
and x86_64, Vivek?
Regards,
Bernhard
next prev parent reply other threads:[~2007-02-14 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 18:57 [Fastboot] Zero size /proc/vmcore on ia64 Bernhard Walle
2007-02-12 21:49 ` Bernhard Walle
2007-02-13 1:08 ` Zou, Nanhai
2007-02-14 1:38 ` Horms
2007-02-14 19:59 ` Bernhard Walle [this message]
2007-02-15 2:15 ` Magnus Damm
2007-02-15 2:28 ` Horms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070214195944.GA18114@strauss.suse.de \
--to=bwalle@novell.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox