From: Len Brown <lenb@kernel.org>
To: John Keller <jpk@sgi.com>
Cc: linux-acpi@vger.kernel.org, ayoung@sgi.com,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] - acpi_boot_init() making bad check on return code
Date: Sat, 17 Feb 2007 03:04:38 +0000 [thread overview]
Message-ID: <200702162204.38607.lenb@kernel.org> (raw)
In-Reply-To: <20070216210727.7407.93052.sendpatchset@attica.americas.sgi.com>
Applied.
thanks,
-Len
On Friday 16 February 2007 16:07, John Keller wrote:
> acpi_boot_init() is making a bad check on the return
> status from acpi_table_parse(). acpi_table_parse() now
> returns zero on success, one on failure.
>
> Signed-off-by: Aaron Young <ayoung@sgi.com>
> ---
>
> Index: release/arch/ia64/kernel/acpi.c
> =================================> --- release.orig/arch/ia64/kernel/acpi.c 2007-02-16 08:58:10.000000000 -0600
> +++ release/arch/ia64/kernel/acpi.c 2007-02-16 09:03:16.893360100 -0600
> @@ -651,7 +651,7 @@ int __init acpi_boot_init(void)
> * information -- the successor to MPS tables.
> */
>
> - if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt) < 1) {
> + if (acpi_table_parse(ACPI_SIG_MADT, acpi_parse_madt)) {
> printk(KERN_ERR PREFIX "Can't find MADT\n");
> goto skip_madt;
> }
> @@ -702,7 +702,7 @@ int __init acpi_boot_init(void)
> * gets interrupts such as power and sleep buttons. If it's not
> * on a Legacy interrupt, it needs to be setup.
> */
> - if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt) < 1)
> + if (acpi_table_parse(ACPI_SIG_FADT, acpi_parse_fadt))
> printk(KERN_ERR PREFIX "Can't find FADT\n");
>
> #ifdef CONFIG_SMP
> -
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2007-02-17 3:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 21:07 [PATCH 1/1] - acpi_boot_init() making bad check on return code John Keller
2007-02-17 3:04 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200702162204.38607.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=ayoung@sgi.com \
--cc=jpk@sgi.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox