From: Horms <horms@verge.net.au>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch 1/3] IA64: put kdump_find_rsvd_region in __init
Date: Wed, 07 Mar 2007 01:03:21 +0000 [thread overview]
Message-ID: <20070307010319.GH17090@verge.net.au> (raw)
In-Reply-To: <20070306073755.795769464@tabatha.lab.ultramonkey.org>
On Tue, Mar 06, 2007 at 04:34:44PM +0800, Zou, Nanhai wrote:
> > -----Original Message-----
> > From: Horms [mailto:horms@verge.net.au]
> > Sent: 2007年3月6日 15:29
> > To: Linux-IA64; fastboot@lists.osdl.org
> > Cc: Luck, Tony; Zou, Nanhai; Magnus Damm
> > Subject: [patch 1/3] IA64: put kdump_find_rsvd_region in __init
> >
> > kdump_find_rsvd_region() is only called by
> > reserve_memory() which is in __init, so it seems that
> > kdump_find_rsvd_region() should also be in there.
> >
> > Signed-off-by: Simon Horman <horms@verge.net.au>
> >
> > Index: linux-2.6/arch/ia64/kernel/efi.c
> > =================================> > --- linux-2.6.orig/arch/ia64/kernel/efi.c 2007-03-06 16:30:10.000000000
> > +0900
> > +++ linux-2.6/arch/ia64/kernel/efi.c 2007-03-06 16:30:13.000000000 +0900
> > @@ -1136,7 +1136,7 @@
> > /* find a block of memory aligned to 64M exclude reserved regions
> > rsvd_regions are sorted
> > */
> > -unsigned long
> > +unsigned long __init
> > kdump_find_rsvd_region (unsigned long size,
> > struct rsvd_region *r, int n)
> > {
> >
> > --
> >
> This patch looks good to me.
Thanks, it it ok if I repost the patch with Acked-by: you ?
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
prev parent reply other threads:[~2007-03-07 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-06 7:28 [patch 1/3] IA64: put kdump_find_rsvd_region in __init Horms
2007-03-06 8:34 ` Zou, Nanhai
2007-03-07 1:03 ` Horms [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070307010319.GH17090@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox