From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bernhard Walle Date: Thu, 22 Mar 2007 22:45:34 +0000 Subject: Re: [PATCH] Fix irqpoll on IA64 (timer interrupt != 0) Message-Id: <20070322224534.GA12791@sykes.suse.de> List-Id: References: <20070320150027.GA18143@strauss.suse.de> <20070322140922.a59bea5c.akpm@linux-foundation.org> <1174598601.10840.231.camel@localhost.localdomain> In-Reply-To: <1174598601.10840.231.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Gleixner Cc: Andrew Morton , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar Hello, * Thomas Gleixner [2007-03-22 22:23]: > > > Also, the code presently passes the magic IRQ number into the generic IRQ > > code. I wonder if we'd get a more pleasing result if we were to make the > > generic IRQ code call _out_ to the architecture: > > > Then, ia64 can implement arch_is_irqpoll_irq() and it can do whatever it > > wants in there. > > > > The __attribute__((weak)) thing adds a little bit of overhead, but I don't > > think this is a fastpath? > > Well, depends what you consider a fastpath. When noirqdebug = 0, it is > called on every interrupt. I think that function is only called if irqfixup = 2, because if the first condition in the expression is wrong, the evaluation of the expression is aborted in C. Regards, Bernhard