Re: [PATCH] remove unused TIF_NOTIFY_RESUME (take 2)

Stephane Eranian
2007-07-30T17:42:09Z

Andrew,

On Mon, Jul 30, 2007 at 10:21:15AM -0700, Andrew Morton wrote:
> On Mon, 30 Jul 2007 02:30:34 -0700 Stephane Eranian <eranian@hpl.hp.com> wrote:
>
> > This following patch removes the TIF_NOTIFY_RESUME flag for thread_info. It is unused
> > on all but the IA-64 architecture. This is take 2 of this patch. In this version,
> > The definition is removed but no re-numbering of the TIF flags is done to minimize
> > the possibility of errors and reduce the size of the patch.
> >
> > For IA-64, we ran out of low-order bits (first 7 bits). Adding a bit for perfmon
> > would cause important code rescheduling changes in the kernel entry/exit path. Instead,
> > we replace TIF_NOTIFY_RESUME with TIF_PERFMON_WORK. This way we get very close to what the
> > new perfmon code base is doing.
>
> This has been (painfully) maintained in -mm for quite a long time. I've
> been waiting for everyone else to merge their stuff so I can get it in
> without disrupting them. This has now happened.
>
> I think it'd be better to merge the larger patch - it's a bit tidier and
> more tested, OK?
>
I appreciate your effort and understand your pain at maintaining this kind
of patch. It seems that neither you or myself have received any complaints
on this patch so far, so I am fine with you using the older version instead.

Thanks.

--
-Stephane