From: Sam Ravnborg <sam@ravnborg.org>
To: Prarit Bhargava <prarit@redhat.com>, len.brown@intel.com
Cc: Christoph Lameter <clameter@sgi.com>,
"Luck, Tony" <tony.luck@intel.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
David Chinner <dgc@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH] acpi: fix section mismatch warning in asus + toshiba
Date: Thu, 31 May 2007 20:29:03 +0000 [thread overview]
Message-ID: <20070531202903.GE27305@uranus.ravnborg.org> (raw)
In-Reply-To: <20070531202440.GD27305@uranus.ravnborg.org>
Fix following section mismatch warnings in acpi
WARNING: drivers/acpi/asus_acpi.o(.init.text+0xb7): Section mismatch: reference to .exit.text: (after 'init_module')
WARNING: o-i386/drivers/acpi/toshiba_acpi.o(.init.text+0x13a): Section mismatch: reference to .exit.text: (after 'init_module')
The exit function is used in the init function during an error codition.
As __exit may be discarded during link-time / run-time this is no good.
Do not mark the exit function __exit.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
Updated patch that covers both drivers.
Sam
diff --git a/drivers/acpi/asus_acpi.c b/drivers/acpi/asus_acpi.c
index b770dea..6d7d415 100644
--- a/drivers/acpi/asus_acpi.c
+++ b/drivers/acpi/asus_acpi.c
@@ -1357,7 +1357,7 @@ static struct backlight_ops asus_backlight_data = {
.update_status = set_brightness_status,
};
-static void __exit asus_acpi_exit(void)
+static void asus_acpi_exit(void)
{
if (asus_backlight_device)
backlight_device_unregister(asus_backlight_device);
diff --git a/drivers/acpi/toshiba_acpi.c b/drivers/acpi/toshiba_acpi.c
index 3906d47..1cfbecb 100644
--- a/drivers/acpi/toshiba_acpi.c
+++ b/drivers/acpi/toshiba_acpi.c
@@ -538,7 +538,7 @@ static struct backlight_ops toshiba_backlight_data = {
.update_status = set_lcd_status,
};
-static void __exit toshiba_acpi_exit(void)
+static void toshiba_acpi_exit(void)
{
if (toshiba_backlight_device)
backlight_device_unregister(toshiba_backlight_device);
next prev parent reply other threads:[~2007-05-31 20:29 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070523063154.GR85884050@sgi.com>
2007-05-23 6:43 ` BUG: sleeping function called from invalid context at Andrew Morton
2007-05-23 17:44 ` BUG: sleeping function called from invalid context at kernel/fork.c:385 Luck, Tony
2007-05-30 3:30 ` David Chinner
2007-05-30 4:44 ` David Chinner
2007-05-30 20:11 ` Luck, Tony
2007-05-30 22:39 ` BUG: sleeping function called from invalid context at Christoph Lameter
2007-05-31 0:53 ` BUG: sleeping function called from invalid context at kernel/fork.c:385 David Chinner
2007-06-04 5:14 ` Peter Chubb
2007-05-30 23:19 ` Luck, Tony
2007-05-30 23:31 ` BUG: sleeping function called from invalid context at Christoph Lameter
2007-05-30 23:34 ` Randy Dunlap
2007-05-30 23:53 ` Christoph Lameter
2007-05-30 23:55 ` BUG: sleeping function called from invalid context at kernel/fork.c:385 Randy Dunlap
2007-05-31 0:09 ` BUG: sleeping function called from invalid context at Christoph Lameter
2007-05-31 6:12 ` Randy Dunlap
2007-05-31 4:43 ` BUG: sleeping function called from invalid context at kernel/fork.c:385 Sam Ravnborg
2007-05-30 23:56 ` Yu, Fenghua
2007-05-31 2:37 ` Luck, Tony
2007-05-31 3:19 ` BUG: sleeping function called from invalid context at Christoph Lameter
2007-05-31 15:20 ` BUG: sleeping function called from invalid context at kernel/fork.c:385 Prarit Bhargava
2007-05-31 19:54 ` Sam Ravnborg
2007-05-31 20:04 ` Sam Ravnborg
2007-05-31 20:08 ` [PATCH] net/hp100: fix section mismatch warning Sam Ravnborg
2007-05-31 20:17 ` [PATCH] kvm: fix section mismatch warning in kvm-intel.o Sam Ravnborg
2007-05-31 20:24 ` [PATCH] acpi: fix section mismatch warning in asus_acpi.o Sam Ravnborg
2007-05-31 20:29 ` Sam Ravnborg [this message]
2007-05-31 20:46 ` [PATCH] isdn: fix section mismatch warnings Sam Ravnborg
2007-05-31 20:51 ` [PATCH] microcode: fix section mismatch warning Sam Ravnborg
2007-05-31 20:42 ` BUG: sleeping function called from invalid context at Christoph Lameter
2007-06-01 3:18 ` BUG: sleeping function called from invalid context at kernel/fork.c:385 Luck, Tony
2007-06-01 3:31 ` Prarit Bhargava
2007-06-01 4:05 ` BUG: sleeping function called from invalid context at Christoph Lameter
2007-06-01 4:17 ` BUG: sleeping function called from invalid context at kernel/fork.c:385 Sam Ravnborg
2007-06-01 4:45 ` BUG: sleeping function called from invalid context at Christoph Lameter
2007-06-01 6:42 ` BUG: sleeping function called from invalid context at kernel/fork.c:385 Sam Ravnborg
2007-06-01 8:00 ` Luck, Tony
2007-06-01 10:30 ` Prarit Bhargava
2007-06-05 14:55 ` linux-ia64 build warning messages Russ Anderson
2007-06-07 5:00 ` Peter Chubb
2007-06-01 10:37 ` BUG: sleeping function called from invalid context at kernel/fork.c:385 Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070531202903.GE27305@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=dgc@sgi.com \
--cc=len.brown@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=randy.dunlap@oracle.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox