From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Morton <akpm@linux-foundation.org>
Date: Fri, 20 Jul 2007 20:17:28 +0000
Subject: Re: [IA64] Add mapping table between irq and vector
Message-Id: <20070720131728.a7335d92.akpm@linux-foundation.org>
List-Id: <linux-ia64.vger.kernel.org>
References: <200707201959.l6KJxHAu019185@hera.kernel.org>
In-Reply-To: <200707201959.l6KJxHAu019185@hera.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>, Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org

On Fri, 20 Jul 2007 19:59:17 GMT
Linux Kernel Mailing List <linux-kernel@vger.kernel.org> wrote:

> +	BUG_ON(bind_irq_vector(irq, vector));

It's not good practice to do assert(expression-with-side-effects).  Because
if someone wants to create a build which has all the assertions disabled,
the resulting binary will not work.

In the present implementation our BUG_ON(expression) will evaluate
`expression' even if CONFIG_BUG=n.  But that's totally lame and we are just
leaving optimisation opportunities on the floor.

Our objective _should_ be to make BUG_ON(expr) generate no code at all if
CONFIG_BUG=n.

So please, prefer to do

	if (bind_irq_vector(irq, vector))
		BUG();