From: Sam Ravnborg <sam@ravnborg.org>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] ia64: fix a few section mismatch warnings
Date: Sat, 28 Jul 2007 06:15:51 +0000 [thread overview]
Message-ID: <20070728061551.GA21626@uranus.ravnborg.org> (raw)
In-Reply-To: <617E1C2C70743745A92448908E030B2A0209BADF@scsmsx411.amr.corp.intel.com>
On Fri, Jul 27, 2007 at 03:32:13PM -0700, Luck, Tony wrote:
> - mca_data = alloc_bootmem(sizeof(struct ia64_mca_cpu)
> - * NR_CPUS + KERNEL_STACK_SIZE);
> + mca_data = mca_bootmem(NR_CPUS + KERNEL_STACK_SIZE);
>
> Oops. You moved the multiply by sizeof(struct ia64_mca_cpu) up into
> the mca_bootmem() function to make it very specific to this use. But
> mutiply has higher precedence than addition.
Oh crap - good catch.
Shall I resubmit a corrected patch?
Sam
next prev parent reply other threads:[~2007-07-28 6:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 21:01 [PATCH] ia64: fix a few section mismatch warnings Sam Ravnborg
2007-07-27 1:18 ` Al Viro
2007-07-27 4:27 ` Sam Ravnborg
2007-07-27 4:36 ` Al Viro
2007-07-27 5:49 ` Sam Ravnborg
2007-07-27 7:44 ` Sam Ravnborg
2007-07-27 22:32 ` Luck, Tony
2007-07-28 6:15 ` Sam Ravnborg [this message]
2007-07-30 18:41 ` Luck, Tony
2007-07-30 20:50 ` [PATCH v3] " Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070728061551.GA21626@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox