public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Dimitri Sivanich <sivanich@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] disable irq's and check need_resched before safe_halt
Date: Wed, 08 Aug 2007 15:01:36 +0000	[thread overview]
Message-ID: <20070808150136.GB22884@sgi.com> (raw)
In-Reply-To: <20070807134932.GA30447@sgi.com>

On Tue, Aug 07, 2007 at 02:26:16PM -0700, Ken Chen wrote:
> I'm horrified to see the same code coming back: doing interrupt
> enable/disable in the most inner while loop.  Disable interrupt is
> just crude, but I suppose that's the only way to resolve the race
> condition?  Looking at other arch like x86_64, it is also doing the
> same thing.

If anyone can suggest a better alternative to fix this race condition,
I'd certainly consider it.

I suppose one alternative might be to move the local_irq_enable()
down into the default_idle loop so that we don't have to enable and
disable irq's the first time through if pal_halt will be called.

  parent reply	other threads:[~2007-08-08 15:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-07 13:49 [PATCH] disable irq's and check need_resched before safe_halt Dimitri Sivanich
2007-08-07 20:11 ` Luck, Tony
2007-08-07 21:26 ` Ken Chen
2007-08-08 15:01 ` Dimitri Sivanich [this message]
2007-08-09  3:36 ` Hidetoshi Seto
2007-08-09 12:41 ` Dimitri Sivanich
2007-08-13 20:36 ` Luck, Tony

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070808150136.GB22884@sgi.com \
    --to=sivanich@sgi.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox