From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Christoph Lameter <clameter@sgi.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
mingo@redhat.com, linux-ia64@vger.kernel.org
Subject: Re: [PATCH] slub - Use local_t protection
Date: Wed, 05 Sep 2007 13:03:44 +0000 [thread overview]
Message-ID: <20070905130344.GA11880@Krystal> (raw)
In-Reply-To: <Pine.LNX.4.64.0709041344040.6376@schroedinger.engr.sgi.com>
* Christoph Lameter (clameter@sgi.com) wrote:
> On Tue, 4 Sep 2007, Mathieu Desnoyers wrote:
>
> > @@ -1566,12 +1565,13 @@ redo:
> > object[c->offset]) != object))
> > goto redo;
> >
> > - put_cpu();
> > + local_exit(flags);
> > if (unlikely((gfpflags & __GFP_ZERO)))
> > memset(object, 0, c->objsize);
> >
> > return object;
> > slow:
> > + local_exit(flags);
>
> Here we can be rescheduled to another processors.
>
> > return __slab_alloc(s, gfpflags, node, addr, c)
>
> c may point to the wrong processor.
Good point. the current CPU is not updated at the beginning of the
slow path.
I'll post the updated patchset. Comments are welcome, especially about
the naming scheme which is currently awkward.
Mathieu
--
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2007-09-05 13:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1188197539.6114.426.camel@twins>
[not found] ` <Pine.LNX.4.64.0708271237580.5056@schroedinger.engr.sgi.com>
[not found] ` <20070827202203.GB5653@Krystal>
[not found] ` <Pine.LNX.4.64.0708271324001.5884@schroedinger.engr.sgi.com>
[not found] ` <20070827203913.GA7416@Krystal>
[not found] ` <Pine.LNX.4.64.0708271401070.6435@schroedinger.engr.sgi.com>
[not found] ` <20070827211003.GA10627@Krystal>
[not found] ` <Pine.LNX.4.64.0708271421130.6566@schroedinger.engr.sgi.com>
[not found] ` <20070827213845.GB9748@Krystal>
[not found] ` <Pine.LNX.4.64.0708271510020.8783@schroedinger.engr.sgi.com>
[not found] ` <20070827222715.GA16982@Krystal>
2007-08-28 1:26 ` [PATCH] SLUB use cmpxchg_local Christoph Lameter
2007-08-28 12:07 ` Mathieu Desnoyers
2007-08-28 19:42 ` Christoph Lameter
2007-09-04 20:02 ` Mathieu Desnoyers
2007-09-04 20:03 ` [PATCH] local_t protection (critical section) Mathieu Desnoyers
2007-09-04 20:04 ` [PATCH] slub - Use local_t protection Mathieu Desnoyers
2007-09-04 20:45 ` Christoph Lameter
2007-09-05 13:03 ` Mathieu Desnoyers [this message]
2007-09-05 13:04 ` [PATCH] local_t protection (critical section) Mathieu Desnoyers
2007-09-12 22:33 ` Christoph Lameter
2007-09-12 23:00 ` Mathieu Desnoyers
2007-09-05 13:06 ` [PATCH] slub - Use local_t protection Mathieu Desnoyers
2007-09-12 22:28 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070905130344.GA11880@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox