From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Mon, 05 Nov 2007 02:13:31 +0000 Subject: Re: [PATCH] iounmap after ioremap in error path: arch/ia64/pci/pci.c Message-Id: <20071105021330.GE16909@verge.net.au> List-Id: References: <472D0612.30301@tiscali.nl> In-Reply-To: <472D0612.30301@tiscali.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-ia64@vger.kernel.org On Sun, Nov 04, 2007 at 12:36:50AM +0100, Roel Kluin wrote: > Do iounmap when too many IO port spaces were encountered > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> This looks correct to me, so long as calling iounmap() actually reverses ioremap() in this case. > --- > diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c > index 488e48a..13a05d7 100644 > --- a/arch/ia64/pci/pci.c > +++ b/arch/ia64/pci/pci.c > @@ -154,6 +154,7 @@ new_space (u64 phys_base, int sparse) > return i; > > if (num_io_spaces = MAX_IO_SPACES) { > + iounmap(mmio_base); > printk(KERN_ERR "PCI: Too many IO port spaces " > "(MAX_IO_SPACES=%lu)\n", MAX_IO_SPACES); > return ~0; > - > To unsubscribe from this list: send the line "unsubscribe linux-ia64" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Horms H: http://www.vergenet.net/~horms/ W: http://www.valinux.co.jp/en/