Re: [PATCH] iounmap if tioce_kern_init fails in ia64/sn/pci/tioce_provider.c

Simon Horman
2007-11-05T02:17:20Z

On Sun, Nov 04, 2007 at 12:12:23PM +0100, Roel Kluin wrote:
> Do iounmap if tioce_kern_init fails

This is covered by a subsequent patch, right?

> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/arch/ia64/sn/pci/tioce_provider.c b/arch/ia64/sn/pci/tioce_provider.c
> index cee9379..128ed07 100644
> --- a/arch/ia64/sn/pci/tioce_provider.c
> +++ b/arch/ia64/sn/pci/tioce_provider.c
> @@ -1008,6 +1008,7 @@ tioce_bus_fixup(struct pcibus_bussoft *prom_bussoft, struct pci_controller *cont
>
> tioce_kern = tioce_kern_init(tioce_common);
> if (tioce_kern = NULL) {
> + iounmap(tioce_common->ce_pcibus.bs_base);
> kfree(tioce_common);
> return NULL;
> }
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/