From: Simon Horman <horms@verge.net.au>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: tony.luck@intel.com, LKML <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] IA64 efi: make full use of macro efi_md_size
Date: Wed, 14 Nov 2007 20:55:10 +0000 [thread overview]
Message-ID: <20071114205459.GC2368@verge.net.au> (raw)
In-Reply-To: <4737AF9D.7070403@cn.fujitsu.com>
On Mon, Nov 12, 2007 at 09:42:53AM +0800, Li Zefan wrote:
> Macro efi_md_size is defined in efi.c, and here we apply it
> throughout efi.c.
>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
This looks correct to me.
Acked-by: Simon Horman <horms@verge.net.au>
> ---
> arch/ia64/kernel/efi.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/ia64/kernel/efi.c b/arch/ia64/kernel/efi.c
> index 0e4ef20..7392d7b 100644
> --- a/arch/ia64/kernel/efi.c
> +++ b/arch/ia64/kernel/efi.c
> @@ -369,7 +369,7 @@ efi_get_pal_addr (void)
> continue;
> }
>
> - if (md->num_pages << EFI_PAGE_SHIFT > IA64_GRANULE_SIZE)
> + if (efi_md_size(md) > IA64_GRANULE_SIZE)
> panic("Woah! PAL code size bigger than a granule!");
>
> #if EFI_DEBUG
> @@ -377,7 +377,7 @@ efi_get_pal_addr (void)
>
> printk(KERN_INFO "CPU %d: mapping PAL code [0x%lx-0x%lx) into [0x%lx-0x%lx)\n",
> smp_processor_id(), md->phys_addr,
> - md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT),
> + md->phys_addr + efi_md_size(md),
> vaddr & mask, (vaddr & mask) + IA64_GRANULE_SIZE);
> #endif
> return __va(md->phys_addr);
> @@ -522,7 +522,7 @@ efi_init (void)
> md = p;
> printk("mem%02u: type=%u, attr=0x%lx, range=[0x%016lx-0x%016lx) (%luMB)\n",
> i, md->type, md->attribute, md->phys_addr,
> - md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT),
> + md->phys_addr + efi_md_size(md),
> md->num_pages >> (20 - EFI_PAGE_SHIFT));
> }
> }
> @@ -655,7 +655,7 @@ efi_memory_descriptor (unsigned long phys_addr)
> for (p = efi_map_start; p < efi_map_end; p += efi_desc_size) {
> md = p;
>
> - if (phys_addr - md->phys_addr < (md->num_pages << EFI_PAGE_SHIFT))
> + if (phys_addr - md->phys_addr < efi_md_size(md))
> return md;
> }
> return NULL;
> @@ -1159,7 +1159,7 @@ efi_initialize_iomem_resources(struct resource *code_resource,
>
> res->name = name;
> res->start = md->phys_addr;
> - res->end = md->phys_addr + (md->num_pages << EFI_PAGE_SHIFT) - 1;
> + res->end = md->phys_addr + efi_md_size(md) - 1;
> res->flags = flags;
>
> if (insert_resource(&iomem_resource, res) < 0)
> --
> 1.5.3.rc7
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Horms, California Edition
prev parent reply other threads:[~2007-11-14 20:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-12 1:42 [PATCH] IA64 efi: make full use of macro efi_md_size Li Zefan
2007-11-14 20:55 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071114205459.GC2368@verge.net.au \
--to=horms@verge.net.au \
--cc=akpm@linux-foundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox