From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Tue, 20 Nov 2007 06:54:33 +0000 Subject: Re: [PATCH 01/59] arch/ia64: Add missing "space" Message-Id: <20071120065431.GC10490@verge.net.au> List-Id: References: <1195523331-15303-1-git-send-email-joe@perches.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: linux-kernel@vger.kernel.org, Jes Sorensen , Tony Luck , linux-altix@sgi.com, linux-ia64@vger.kernel.org [snip] > diff --git a/arch/ia64/kernel/kprobes.c b/arch/ia64/kernel/kprobes.c > index 5fd65d8..90518e4 100644 > --- a/arch/ia64/kernel/kprobes.c > +++ b/arch/ia64/kernel/kprobes.c > @@ -182,8 +182,8 @@ static int __kprobes unsupported_inst(uint template, uint slot, > qp = kprobe_inst & 0x3f; > if (is_cmp_ctype_unc_inst(template, slot, major_opcode, kprobe_inst)) { > if (slot = 1 && qp) { > - printk(KERN_WARNING "Kprobes on cmp unc" > - "instruction on slot 1 at <0x%lx>" > + printk(KERN_WARNING "Kprobes on cmp unc " > + "instruction on slot 1 at <0x%lx> " > "is not supported\n", addr); > return -EINVAL; > > @@ -221,8 +221,8 @@ static int __kprobes unsupported_inst(uint template, uint slot, > * bit 12 to be equal to 1 > */ > if (slot = 1 && qp) { > - printk(KERN_WARNING "Kprobes on test bit" > - "instruction on slot at <0x%lx>" > + printk(KERN_WARNING "Kprobes on test bit " > + "instruction on slot at <0x%lx> " > "is not supported\n", addr); > return -EINVAL; > } Is it really neccessary for this fragment to create a line that is greater than 80 characters long? Persumably the entire reason that the printk line was split in the first place was to avoid a long line. [snip] -- Horms