From: Kyle McMartin <kyle@mcmartin.ca>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "de Dinechin,
Christophe (Integrity VM)" <christophe.de-dinechin@hp.com>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Picco, Robert W." <robert.picco@hp.com>,
"tony.luck@intel.com" <tony.luck@intel.com>
Subject: Re: [PATCH] ia64: Avoid unnecessary TLB flushes when allocating memory
Date: Tue, 18 Dec 2007 06:00:15 +0000 [thread overview]
Message-ID: <20071218060015.GE16467@fattire.cabal.ca> (raw)
In-Reply-To: <20071218100545.14ae2c73.kamezawa.hiroyu@jp.fujitsu.com>
On Tue, Dec 18, 2007 at 10:05:45AM +0900, KAMEZAWA Hiroyuki wrote:
> On Thu, 13 Dec 2007 15:03:07 +0000
>
> > + if (mm != active_mm) {
> > + /* Restore region IDs for mm */
> > + if (mm && active_mm) {
> > + activate_context(mm);
> > + } else {
> > + flush_tlb_all();
> > + return;
> > + }
> > }
> should be
>
platform_global_tlb_purge is already (and afaict, only) called under
preempt_disable already. then again, the sn2 global_tlb_purge
does it, so possibly for completeness sake it should be added here as
well?
regards, kyle
next prev parent reply other threads:[~2007-12-18 6:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 15:03 [PATCH] ia64: Avoid unnecessary TLB flushes when allocating memory de Dinechin, Christophe (Integrity VM)
2007-12-13 21:07 ` Luck, Tony
2007-12-14 17:17 ` [PATCH] ia64: Avoid unnecessary TLB flushes when allocating de Dinechin, Christophe (Integrity VM)
2007-12-14 18:19 ` [PATCH] ia64: Avoid unnecessary TLB flushes when allocating memory Luck, Tony
2007-12-17 10:42 ` [PATCH] ia64: Avoid unnecessary TLB flushes when allocating de Dinechin, Christophe (Integrity VM)
2007-12-18 1:05 ` KAMEZAWA Hiroyuki
2007-12-18 6:00 ` Kyle McMartin [this message]
2007-12-18 6:26 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071218060015.GE16467@fattire.cabal.ca \
--to=kyle@mcmartin.ca \
--cc=christophe.de-dinechin@hp.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robert.picco@hp.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox