From: Robin Holt <holt@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATH] Reduce per_cpu allocations to minimum needed for bootV3.
Date: Sun, 10 Feb 2008 14:06:06 +0000 [thread overview]
Message-ID: <20080210140606.GN3875@sgi.com> (raw)
In-Reply-To: <20080208225015.GK3875@sgi.com>
Tony,
My laziness keeps making me want to just set it to 32 and call it good.
At the same time, I have a nagging feeling we should really rework this
considerably. I don't see a compelling reason to pre-allocate anything
except the boot cpus per_cpu area. The others, I would guess, could be
alloc_bootmem_node allocations on the cpu's node at per_cpu_init time.
We could maintain an array of pre-nulled per_cpu_data pointers, seed
with the reservation on node 0, and then alloc_bootmem_node and init
whenever per_cpu_init finds a NULL.
I have not looked at this too closely. I would guess it is far too
invasive for this point in the release cycle anyway. I don't think I
could have this done and tested within a week.
Would you mind putting in the patch as it was with 32? If so, would you
want that as a #define? We could come back to the alloc_bootmem_node
idea when we have more time to think it over. Either way, I would not
think it is significantly worse than the extreme space wasting we see
as NR_CPUS increases.
Thanks,
Robin
next prev parent reply other threads:[~2008-02-10 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-08 22:50 [PATH] Reduce per_cpu allocations to minimum needed for boot V3 Robin Holt
2008-02-08 23:10 ` Luck, Tony
2008-02-08 23:20 ` [PATH] Reduce per_cpu allocations to minimum needed for boot Robin Holt
2008-02-09 0:09 ` [PATH] Reduce per_cpu allocations to minimum needed for bootV3 Luck, Tony
2008-02-10 14:06 ` Robin Holt [this message]
2008-02-11 18:41 ` Luck, Tony
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080210140606.GN3875@sgi.com \
--to=holt@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox