From: Christoph Hellwig <hch@infradead.org>
To: linux-ia64@vger.kernel.org
Subject: Re: git-nfsd on ia64
Date: Sun, 17 Feb 2008 13:13:14 +0000 [thread overview]
Message-ID: <20080217131314.GA12056@infradead.org> (raw)
In-Reply-To: <20080215223943.d12b8eb5.akpm@linux-foundation.org>
On Sat, Feb 16, 2008 at 08:27:06PM -0500, J. Bruce Fields wrote:
> > This should have been done in the first place, IMO. Avoid header file
> > dependencies, faster compile, avoid crap like the above.
>
> OK. So as a general rule, we should skip the include any time when a
> few structure declarations would suffice?
Yes. Unessecary includes should always be avoided, and forward
declarations are a nice way to avoid includes.
> Hm. It also seems wrong that sys_ia32.c would need to include so many
> nfsd/sunrpc headers. It looks like that should be easy to fix with a
> better organization of the nfsd headers--I'll do that, assuming it's
> considered worthwhile....
Why does it need to include either of these at all? There's nothing
nfs-specific in that file.
next prev parent reply other threads:[~2008-02-17 13:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-16 6:39 git-nfsd on ia64 Andrew Morton
2008-02-16 6:43 ` Andrew Morton
2008-02-17 1:12 ` J. Bruce Fields
2008-02-17 1:18 ` Andrew Morton
2008-02-17 1:27 ` J. Bruce Fields
2008-02-17 13:13 ` Christoph Hellwig [this message]
2008-02-17 13:21 ` Christoph Hellwig
2008-02-17 14:08 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080217131314.GA12056@infradead.org \
--to=hch@infradead.org \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox