From: Dimitri Sivanich <sivanich@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH] SGI Altix mmtimer - allow larger number of timers per node
Date: Mon, 25 Feb 2008 18:33:26 +0000 [thread overview]
Message-ID: <20080225183326.GC9350@sgi.com> (raw)
In-Reply-To: <20080207213552.GA2658@sgi.com>
On Fri, Feb 15, 2008 at 10:54:59PM -0800, Andrew Morton wrote:
>
> drivers/char/mmtimer.c: In function `sgi_timer_del':
> drivers/char/mmtimer.c:607: warning: 't' might be used uninitialized in this function
>
> Are you sure this is absolutely always a false positive? If so,
> we can shut it up with uninitialized_var().
Only 2 ways 't' wouldn't be set at all:
- If 'n' was NULL right away at line 613. We then exit immediatly at line 626.
- If we never found 't->timer = timr', in which case we made it to the end of a branch, and once again 'n' would be NULL and would exit right away at line 626.
So yes, I'm in agreement with your patch to shut it up with uninitialized_var().
prev parent reply other threads:[~2008-02-25 18:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 21:35 [PATCH] SGI Altix mmtimer - allow larger number of timers per node Dimitri Sivanich
2008-02-07 22:08 ` [PATCH] SGI Altix mmtimer - allow larger number of timers per Andrew Morton
2008-02-09 21:49 ` [PATCH] SGI Altix mmtimer - allow larger number of timers per node Dimitri Sivanich
2008-02-12 22:40 ` [PATCH] SGI Altix mmtimer - allow larger number of timers per Andrew Morton
2008-02-16 6:54 ` Andrew Morton
2008-02-25 18:33 ` Dimitri Sivanich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080225183326.GC9350@sgi.com \
--to=sivanich@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox