Re: Tiger oops in ia64_sal_physical_id_info (was [RFC] regression:113134fcbca83619be4c68d0ca66db6093

Russ Anderson
2008-02-27T15:19:16Z

On Wed, Feb 27, 2008 at 06:38:04AM -0800, Luck, Tony wrote:
> > > Did it work before?
> >
> > Yes.
>
> How about a more drastic approach to avoiding the
> problem ... avoid any poking around looking for
> siblings on pre-montecito processors?

I like that idea. No need to look for siblings
on CPUs that do not support siblings.

> diff --git a/arch/ia64/kernel/setup.c b/arch/ia64/kernel/setup.c
> index ebd1a09..7b0e396 100644
> --- a/arch/ia64/kernel/setup.c
> +++ b/arch/ia64/kernel/setup.c
> @@ -736,7 +736,8 @@ identify_cpu (struct cpuinfo_ia64 *c)
> c->threads_per_core = c->cores_per_socket = c->num_log = 1;
> c->socket_id = -1;
>
> - identify_siblings(c);
> + if (cpuid.field.family > 0x1f)
> + identify_siblings(c);
>
> if (c->threads_per_core > smp_num_siblings)
> smp_num_siblings = c->threads_per_core;

--
Russ Anderson, OS RAS/Partitioning Project Lead
SGI - Silicon Graphics Inc rja@sgi.com