From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Date: Thu, 28 Feb 2008 19:24:23 +0000 Subject: Re: 2.6.25-rc2-mm1 - boot hangs on ia64 Message-Id: <20080228112423.fed6add2.akpm@linux-foundation.org> List-Id: References: <20080227103831.423F.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080227071118.GA4638@elte.hu> <20080228192509.BDCF.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080228115041.GA22082@elte.hu> <20080228101343.1b9548e6.akpm@linux-foundation.org> <20080228191214.GA17872@elte.hu> In-Reply-To: <20080228191214.GA17872@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Ingo Molnar Cc: kosaki.motohiro@jp.fujitsu.com, srostedt@redhat.com, Lee.Schermerhorn@hp.com, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, tony.luck@intel.com, mingo@redhat.com, bob.picco@hp.com, eric.whitney@hp.com On Thu, 28 Feb 2008 20:12:14 +0100 Ingo Molnar wrote: > > * Andrew Morton wrote: > > > On Thu, 28 Feb 2008 12:50:41 +0100 Ingo Molnar wrote: > > > > > @@ -1000,7 +1001,7 @@ void release_console_sem(void) > > > * If we try to wake up klogd while printing with the runqueue lock > > > * held, this will deadlock. > > > */ > > > - if (wake_klogd && !runqueue_is_locked()) > > > + if (wake_klogd) > > > wake_up_klogd(); > > > } > > > > I don't think we shoudl have added that hack in the first place. It > > solves a problem which about three developers hit four times in five > > years but it has made kernel logging less reliable for everyone. > > well, the problem was ia64, not a problem on x86 or other platforms. I am referring to the original change which made klogd wakeups unreliable.