Re: [PATCH 2/4] set_restore_sigmask TIF_SIGPENDING

Linus Torvalds
2008-04-08T14:53:15Z

On Tue, 8 Apr 2008, Oleg Nesterov wrote:
>
> We only need this flag as an implicit parameter to the arch dependent do_signal()
> which we can't call directly, and thus it must imply TIF_SIGPENDING, and it
> is not valid after do_signal() (should be cleared). This all looks like
> ERESTART_ magic, why should we add something else ?

I think you're right. I didn't look at the actual code-paths, but my gut
feel says "yes, TIF_RESTORE_SIGMASK should actually have been
-ERESTARTSIGRESTORE". That sounds like the right thing to do.

Linus