From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Date: Tue, 29 Apr 2008 21:33:29 +0000 Subject: Re: [PATCH 1/2] mm: Avoid putting a bad page back on the LRU Message-Id: <20080429143329.3a17ef91.akpm@linux-foundation.org> List-Id: References: <20080428192358.GB14629@sgi.com> In-Reply-To: <20080428192358.GB14629@sgi.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Russ Anderson Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, torvalds@linux-foundation.org, tony.luck@intel.com, clameter@sgi.com On Mon, 28 Apr 2008 14:23:58 -0500 Russ Anderson wrote: > --- test.orig/include/linux/kernel.h 2008-04-25 15:22:07.640501421 -0500 > +++ test/include/linux/kernel.h 2008-04-25 15:42:02.826266036 -0500 > @@ -412,6 +412,7 @@ struct sysinfo { > unsigned long totalhigh; /* Total high memory size */ > unsigned long freehigh; /* Available high memory size */ > unsigned int mem_unit; /* Memory unit size in bytes */ > + unsigned int badpages; /* Number of bad (PG_memerror) pages */ > char _f[20-2*sizeof(long)-sizeof(int)]; /* Padding: libc5 uses this.. */ > }; eek. sys_sysinfo() copies this structure out to userspace verbatim. Increasing its size by four bytes will cause memory scribbles in userspace applications. That's fixable by suitably adjusting sysinfo._f, but given the lack of version information in the sysinfo struct, I'm not sure how useful this change really is.