From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russ Anderson Date: Fri, 09 May 2008 21:07:13 +0000 Subject: Re: [PATCH 3/3] ia64: Call migration code on correctable errors v3 Message-Id: <20080509210713.GA21370@sgi.com> List-Id: References: <20080509151135.GD16523@sgi.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Lameter Cc: linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, Linus Torvalds , Andrew Morton , Tony Luck On Fri, May 09, 2008 at 02:03:19PM -0700, Christoph Lameter wrote: > On Fri, 9 May 2008, Russ Anderson wrote: > > > + local_irq_save(irq_flags); > > The page migration functions expect to be called in non atomic contexts > since they use things like lock_page(). Can you just drop the irq disable? Yes. > The spinlock should not be there either. Page migration serialize via > the LRU. Pages that are to be migrated have to be taken off the LRU > first. There is no danger of two threads trying to migrate the same > page because the second one will not be able to take it off the LRU > anymore. -- Russ Anderson, OS RAS/Partitioning Project Lead SGI - Silicon Graphics Inc rja@sgi.com