Re: [PATCH 5/5] sh: Define elfcorehdr_addr in arch dependent section

Paul Mundt
2008-07-29T14:18:35Z

On Mon, Jul 28, 2008 at 05:15:14PM -0400, Vivek Goyal wrote:
> o Move elfcorehdr_addr definition in arch dependent crash dump file. This is
> equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of
> CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be
> used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or
> not.
>
> o I don't see sh setup code parsing the command line for elfcorehdr_addr. I
> am wondering how does vmcore interface work on sh. Anyway, I am atleast
> defining elfcoredhr_addr so that compilation is not broken on sh.
>
Hmm, you are correct, it seems like it was either lost in a merge
somewhere or I simply neglected to check it in it when I was testing this
stuff initially. Thanks for noticing!

> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>

Acked-by: Paul Mundt <lethal@linux-sh.org>