Re: [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent

Ingo Molnar
2008-07-31T15:29:26Z

* Vivek Goyal <vgoyal@redhat.com> wrote:

> o Move elfcorehdr_addr definition in arch dependent crash dump file. This is
> equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of
> CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be
> used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or
> not.
>
> Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> ---
>
> arch/x86/kernel/crash_dump_32.c | 3 +++
> arch/x86/kernel/crash_dump_64.c | 3 +++
> arch/x86/kernel/setup.c | 8 +++++++-
> 3 files changed, 13 insertions(+), 1 deletion(-)

the x86 bits look fine to me.

Acked-by: Ingo Molnar <mingo@elte.hu>

Ingo