From: Simon Horman <horms@verge.net.au>
To: Linux-kernel <Linux-kernel@vger.kernel.org>, linux-ia64@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Rusty Russell <rusty@rustcorp.com.au>,
Andrew Morton <akpm@linux-foundation.org>,
Al Viro <viro@ZenIV.linux.org.uk>, Mike Travis <travis@sgi.com>
Subject: Re: Regression on ia64 with cpu masks: optimize and clean up
Date: Tue, 29 Jul 2008 09:50:02 +0000 [thread overview]
Message-ID: <20080729095001.GA509@verge.net.au> (raw)
In-Reply-To: <20080729034459.GA11699@verge.net.au>
On Tue, Jul 29, 2008 at 01:45:01PM +1000, Simon Horman wrote:
> Hi,
>
> I haven't had a time to look into this closeley yet,
> but "cpu masks: optimize and clean up cpumask_of_cpu()"
> aka e56b3bc7942982ac2589c942fb345e38bc7a341a causes
> a build failure for me on ia64.
>
> # ia64-unknown-linux-gnu-gcc --version
> ia64-unknown-linux-gnu-gcc (GCC) 3.4.5
> Copyright (C) 2004 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions. There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
>
> # make
> make[1]: `include/asm-ia64/nr-irqs.h' is up to date.
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> CALL scripts/checksyscalls.sh
> CHK include/linux/compile.h
> CC drivers/acpi/processor_throttling.o
> drivers/acpi/processor_throttling.c: In function `acpi_processor_get_throttling':
> drivers/acpi/processor_throttling.c:841: error: invalid lvalue in unary `&'
> drivers/acpi/processor_throttling.c: In function `acpi_processor_set_throttling':
> drivers/acpi/processor_throttling.c:1028: error: invalid lvalue in unary `&'
> drivers/acpi/processor_throttling.c:1059: error: invalid lvalue in unary `&'
> make[2]: *** [drivers/acpi/processor_throttling.o] Error 1
> make[1]: *** [drivers/acpi] Error 2
> make: *** [drivers] Error 2
I'm pretty sure that I am missing something subtle here,
but something that is working for me is:
Index: linux-2.6/include/linux/cpumask.h
=================================--- linux-2.6.orig/include/linux/cpumask.h 2008-07-29 19:03:06.000000000 +1000
+++ linux-2.6/include/linux/cpumask.h 2008-07-29 19:03:16.000000000 +1000
@@ -287,7 +287,7 @@ static inline const cpumask_t *get_cpu_m
* gcc optimizes it out (it's a constant) and there's no huge stack
* variable created:
*/
-#define cpumask_of_cpu(cpu) ({ *get_cpu_mask(cpu); })
+#define cpumask_of_cpu(cpu) (*get_cpu_mask(cpu))
#define CPU_MASK_LAST_WORD BITMAP_LAST_WORD_MASK(NR_CPUS)
next prev parent reply other threads:[~2008-07-29 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 3:45 Regression on ia64 with cpu masks: optimize and clean up Simon Horman
2008-07-29 9:50 ` Simon Horman [this message]
2008-07-29 15:33 ` Regression on ia64 with cpu masks: optimize and clean up cpumask_of_cpu() Mike Travis
2008-07-29 23:18 ` Regression on ia64 with cpu masks: optimize and clean up Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729095001.GA509@verge.net.au \
--to=horms@verge.net.au \
--cc=Linux-kernel@vger.kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=travis@sgi.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox