From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Tue, 29 Jul 2008 14:18:35 +0000 Subject: Re: [PATCH 5/5] sh: Define elfcorehdr_addr in arch dependent section Message-Id: <20080729141835.GC902@linux-sh.org> List-Id: References: <20080727234529.GM6175@verge.net.au> <20080728015117.GA12055@verge.net.au> <20080728024526.GB3334@verge.net.au> <20080728034007.GA30450@verge.net.au> <20080728211025.GA9985@redhat.com> <20080728211156.GB9985@redhat.com> <20080728211314.GC9985@redhat.com> <20080728211408.GD9985@redhat.com> <20080728211514.GE9985@redhat.com> In-Reply-To: <20080728211514.GE9985@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vivek Goyal Cc: Simon Horman , Andrew Morton , Muli Ben-Yehuda , Tony Luck , linux-ia64@vger.kernel.org, Chandru , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Terry Loftin , "Eric W. Biederman" , Ingo Molnar , Linus Torvalds , Paul Mackerras , linuxppc-dev@ozlabs.org On Mon, Jul 28, 2008 at 05:15:14PM -0400, Vivek Goyal wrote: > o Move elfcorehdr_addr definition in arch dependent crash dump file. This is > equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of > CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be > used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or > not. > > o I don't see sh setup code parsing the command line for elfcorehdr_addr. I > am wondering how does vmcore interface work on sh. Anyway, I am atleast > defining elfcoredhr_addr so that compilation is not broken on sh. > Hmm, you are correct, it seems like it was either lost in a merge somewhere or I simply neglected to check it in it when I was testing this stuff initially. Thanks for noticing! > Signed-off-by: Vivek Goyal Acked-by: Paul Mundt