From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ingo Molnar Date: Thu, 31 Jul 2008 15:29:26 +0000 Subject: Re: [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent Message-Id: <20080731152926.GA20909@elte.hu> List-Id: References: <20080727234529.GM6175@verge.net.au> <20080728015117.GA12055@verge.net.au> <20080728024526.GB3334@verge.net.au> <20080728034007.GA30450@verge.net.au> <20080728211025.GA9985@redhat.com> <20080728211156.GB9985@redhat.com> In-Reply-To: <20080728211156.GB9985@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Vivek Goyal Cc: Simon Horman , Andrew Morton , Muli Ben-Yehuda , Tony Luck , linux-ia64@vger.kernel.org, Chandru , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Terry Loftin , "Eric W. Biederman" , Linus Torvalds , Paul Mundt , Paul Mackerras , linuxppc-dev@ozlabs.org * Vivek Goyal wrote: > o Move elfcorehdr_addr definition in arch dependent crash dump file. This is > equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of > CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be > used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or > not. > > Signed-off-by: Vivek Goyal > --- > > arch/x86/kernel/crash_dump_32.c | 3 +++ > arch/x86/kernel/crash_dump_64.c | 3 +++ > arch/x86/kernel/setup.c | 8 +++++++- > 3 files changed, 13 insertions(+), 1 deletion(-) the x86 bits look fine to me. Acked-by: Ingo Molnar Ingo