From: Simon Horman <horms@verge.net.au>
To: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Tony Luck <tony.luck@intel.com>, Keith Owens <kaos@ocs.com.au>
Subject: [patch] IA64: suppress return value of down_trylock() in
Date: Sun, 03 Aug 2008 00:06:58 +0000 [thread overview]
Message-ID: <20080803000654.GA30659@verge.net.au> (raw)
salinfo_work_to_do() intentionally ignores the return value of
down_trylock() and calls up() regardless of if the lock
was taken or not.
This patch suppresses the warning generated by ignoring
this return value - down_trylock() is annotated with __must_check.
(void)down_trylock() was not sufficient.
arch/ia64/kernel/salinfo.c: In function `salinfo_work_to_do':
arch/ia64/kernel/salinfo.c:195: warning: ignoring return value of `down_trylock'
# ia64-unknown-linux-gnu-gcc --version
ia64-unknown-linux-gnu-gcc (GCC) 3.4.5
Copyright (C) 2004 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Signed-off-by: Simon Horman <horms@verge.net.au>
Index: linux-2.6/arch/ia64/kernel/salinfo.c
=================================--- linux-2.6.orig/arch/ia64/kernel/salinfo.c 2008-08-03 09:52:08.000000000 +1000
+++ linux-2.6/arch/ia64/kernel/salinfo.c 2008-08-03 10:03:36.000000000 +1000
@@ -192,7 +192,7 @@ struct salinfo_platform_oemdata_parms {
static void
salinfo_work_to_do(struct salinfo_data *data)
{
- down_trylock(&data->mutex);
+ if (down_trylock(&data->mutex)) { ; }; /* Ignore return value */
up(&data->mutex);
}
next reply other threads:[~2008-08-03 0:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-03 0:06 Simon Horman [this message]
2008-08-03 1:32 ` [patch] IA64: suppress return value of down_trylock() in salinfo_work_to_do() Matthew Wilcox
2008-08-03 1:44 ` Matthew Wilcox
2008-08-03 2:08 ` Keith Owens
2008-08-03 2:43 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080803000654.GA30659@verge.net.au \
--to=horms@verge.net.au \
--cc=kaos@ocs.com.au \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox