From: Ingo Molnar <mingo@elte.hu>
To: "Yu, Fenghua" <fenghua.yu@intel.com>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
"Luck, Tony" <tony.luck@intel.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
David Woodhouse <dwmw2@infradead.org>,
Avi Kivity <avi@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>
Subject: Re: [PATCH 1/2]Add Variable Page Size and IA64 Support in Intel
Date: Fri, 03 Oct 2008 08:54:50 +0000 [thread overview]
Message-ID: <20081003085450.GA27551@elte.hu> (raw)
In-Reply-To: <A6AD88C3F2289247BE726C37303E1EB88408AE54@orsmsx505.amr.corp.intel.com>
* Yu, Fenghua <fenghua.yu@intel.com> wrote:
> >What's this all about? Why do we need #ifdef CONFIG_IA64 here?
> >Doesn't x86 provide its own readq/writeq implementation?
>
> This is a comment from Bjorn.
>
> In my patch, one readq/one writeq are working faster than two
> readl/two writel on IA64. X86 uses two readl/two writel so that the
> code works on both x86 and x86-64 although Intel IOMMU only has x86-64
> version currently. dmar_readq() and dmar_writeq() are in moderate
> performance critical path.
>
> Do you think my current implementation is ok to have #ifdef
> CONFIG_IA64 here? Or I can change X86 to use readq/writeq as well or
> IA64 uses two readl/two writel for clean code?
yes, clean code is very much preferred for a small detail like this.
Ingo
next prev parent reply other threads:[~2008-10-03 8:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BAE9DCEF64577A439B3A37F36F9B691C0339372B@orsmsx418.amr.corp.intel.com>
[not found] ` <617E1C2C70743745A92448908E030B2A02AD5AD7@scsmsx411.amr.corp.intel.com>
2008-05-02 22:26 ` [PATCH] Handle invalid ACPI SLIT table Fenghua Yu
2008-10-01 16:57 ` [PATCH 1/2]Add Variable Page Size and IA64 Support in Intel IOMMU: Generic Part Fenghua Yu
2008-10-02 8:29 ` [PATCH 1/2]Add Variable Page Size and IA64 Support in Intel Ingo Molnar
2008-10-02 22:06 ` Yu, Fenghua
2008-10-03 8:54 ` Ingo Molnar [this message]
2008-10-02 15:31 ` [PATCH 1/2]Add Variable Page Size and IA64 Support in Intel IOMMU: Generic Part Bjorn Helgaas
2008-10-02 21:46 ` [PATCH 1/2]Add Variable Page Size and IA64 Support in Intel Yu, Fenghua
2008-10-03 15:33 ` [PATCH 1/2]Add Variable Page Size and IA64 Support in Intel IOMMU: Generic Part Bjorn Helgaas
2008-10-04 0:21 ` [PATCH 1/2]Add Variable Page Size and IA64 Support in Intel Yu, Fenghua
2008-10-07 0:01 ` [PATCH V2 1/2] Add Variable Page Size and IA64 Support in Intel IOMMU: Generic Part Fenghua Yu
2009-08-04 22:10 ` [PATCH 2/4] Bug Fix drivers/pci/intel-iommu.c: secure sg_next() calling Fenghua Yu
2009-08-05 8:09 ` [PATCH 2/4] Bug Fix drivers/pci/intel-iommu.c: secure David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081003085450.GA27551@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=bjorn.helgaas@hp.com \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox