From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: "Luck, Tony" <tony.luck@intel.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
David Woodhouse <dwmw2@infradead.org>,
Ingo Molnar <mingo@elte.hu>, Avi Kivity <avi@redhat.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH 0/2]Add Variable Page Size and IA64 Support in Intel IOMMU
Date: Fri, 03 Oct 2008 15:50:18 +0000 [thread overview]
Message-ID: <200810030950.19359.bjorn.helgaas@hp.com> (raw)
In-Reply-To: <20081001165606.GA21279@linux-os.sc.intel.com>
On Wednesday 01 October 2008 10:56:06 am Fenghua Yu wrote:
> The following two patches (Intel IOMMU generic patch and ia64 specific patch) together enable Intel IOMMU on IA64 platform. They are applied cleanly on the latest linux-next tree which contains Intel IOMMU interrupt remapping and VT-d driver KVM support code.
General comment (not ia64-related): it looks like you detect the
IOMMU using the static DMAR table. Does the IOMMU also appear in
PCI config space or the ACPI namespace? I expect it would, because
the fact that the DMAR table is static precludes any sort of hot-plug
to add or remove IOMMUs.
If it *is* in config space or the namespace, it would be good to
exercise that discovery path to help shake out firmware bugs. For
example, arch/ia64/hp/common/sba_iommu.c uses acpi_bus_register_driver()
to discover HP IOMMUs. I wouldn't hold the sba_iommu.c discovery code
(most of which I take the blame for) up as a shining example of how to
do things, but it shows the point.
Bjorn
next prev parent reply other threads:[~2008-10-03 15:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 16:56 [PATCH 0/2]Add Variable Page Size and IA64 Support in Intel IOMMU Fenghua Yu
2008-10-03 15:50 ` Bjorn Helgaas [this message]
2008-10-06 19:44 ` [PATCH 0/2]Add Variable Page Size and IA64 Support in Intel Yu, Fenghua
2008-10-07 0:01 ` [PATCH V2 0/2] Add Variable Page Size and IA64 Support in Intel IOMMU Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810030950.19359.bjorn.helgaas@hp.com \
--to=bjorn.helgaas@hp.com \
--cc=akpm@linux-foundation.org \
--cc=avi@redhat.com \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox