From: Robin Holt <holt@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [Patch 4/4] Clear up section mismatch for ioc4_ide_attach_one.
Date: Tue, 09 Dec 2008 11:13:14 +0000 [thread overview]
Message-ID: <20081209111314.GF8970@sgi.com> (raw)
In-Reply-To: <20081208144346.959154466@attica.americas.sgi.com>
On Mon, Dec 08, 2008 at 03:50:06PM -0800, Luck, Tony wrote:
> > The generic_defconfig has three section mismatches. This clears up
> > ioc4_ide_attach_one().
>
> After applying this patch (and parts 2&3 too) I got a build error (using
> gcc 4.3.1 ... which I think is pickier about some of this section stuff):
>
> drivers/ide/sgiioc4.c:533: error: sgiioc4_port_info causes a section type conflict
>
> The declaration for this should really be using __devinitconst rather
> than __devinitdata. I can fold a s/__devinitdata/__devinitconst/ patch
> into this one if that looks OK to you.
That would be wonderful.
Thank you,
Robin
prev parent reply other threads:[~2008-12-09 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 14:43 [Patch 4/4] Clear up section mismatch for ioc4_ide_attach_one Robin Holt
2008-12-08 23:50 ` Luck, Tony
2008-12-09 11:13 ` Robin Holt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081209111314.GF8970@sgi.com \
--to=holt@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox