Re: [PATCH] simnet: convert to net_device_ops

Alexander Beregalov
2008-12-10T11:21:46Z

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]

2008/12/10 David Miller <davem@davemloft.net>:
> From: Alexey Dobriyan <adobriyan@gmail.com>
> Date: Tue, 9 Dec 2008 18:08:27 +0300
>
>> On Tue, Dec 09, 2008 at 05:11:17PM +0300, Alexander Beregalov wrote:
>> > CC arch/ia64/hp/sim/simeth.o
>> > arch/ia64/hp/sim/simeth.c: In function 'simeth_probe1':
>> > arch/ia64/hp/sim/simeth.c:212: error: 'struct net_device' has no member named 'open'
>>
>> [PATCH] simeth: convert to net_device_ops
>>
>> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>
> This doesn't explain the build failure.
>
> Using ->open() and friends should work perfectly fine for drivers not
> yet converted to netdev_ops. The code protected by COMPAT_NET_DEV_OPS
> provides this, and we force that Kconfig option to always be on.
>
> I don't want to add this patch and just shrug off this build failure.
> If this build failures, we should be seeing 200 other drivers not
> build too.
>
> I suspect something is messed up with this person's kernel config
> or similar.
>

Thanks for explanation.
Is it better?

arch/ia64/hp/sim/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/ia64/hp/sim/Kconfig b/arch/ia64/hp/sim/Kconfig
index f92306b..8d513a8 100644
--- a/arch/ia64/hp/sim/Kconfig
+++ b/arch/ia64/hp/sim/Kconfig
@@ -4,6 +4,7 @@ menu "HP Simulator drivers"

config HP_SIMETH
bool "Simulated Ethernet "
+ depends on NET

config HP_SIMSERIAL
bool "Simulated serial driver support"

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: hp-sim-kconfig.patch --]
[-- Type: text/x-patch; name=hp-sim-kconfig.patch, Size: 417 bytes --]

arch/ia64/hp/sim/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/ia64/hp/sim/Kconfig b/arch/ia64/hp/sim/Kconfig
index f92306b..8d513a8 100644
--- a/arch/ia64/hp/sim/Kconfig
+++ b/arch/ia64/hp/sim/Kconfig
@@ -4,6 +4,7 @@ menu "HP Simulator drivers"

config HP_SIMETH
bool "Simulated Ethernet "
+ depends on NET

config HP_SIMSERIAL
bool "Simulated serial driver support"