From: Ingo Molnar <mingo@elte.hu>
To: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH -tip] IA64: fix the compile error on IA64_DIG_VTD
Date: Tue, 27 Jan 2009 14:46:02 +0000 [thread overview]
Message-ID: <20090127144602.GA12183@elte.hu> (raw)
In-Reply-To: <20090127233530U.fujita.tomonori@lab.ntt.co.jp>
* FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp> wrote:
> Sorry about fallout from my dma mapping ops unification.
>
> > From: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> Subject: [PATCH] IA64: fix the compile error on IA64_DIG_VTD
>
> This moves iommu_detected to arch/ia64/kernel/dma-mapping.c from
> arch/ia64/kernel/pci-swiotlb.c to fix the following error on on
> IA64_DIG_VTD:
>
> arch/ia64/kernel/built-in.o: In function `pci_iommu_init':
> pci-dma.c:(.init.text+0xa021): undefined reference to `iommu_detected'
> pci-dma.c:(.init.text+0xa030): undefined reference to `iommu_detected'
> drivers/built-in.o: In function `detect_intel_iommu':
> (.init.text+0x11c0): undefined reference to `iommu_detected'
> drivers/built-in.o: In function `detect_intel_iommu':
> (.init.text+0x11e1): undefined reference to `iommu_detected'
>
> iommu_detected is used to handle IOMMUs so I guess that
> arch/ia64/kernel/dma-mapping.c is ok (there might be a better place
> for it though).
>
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
> ---
> arch/ia64/kernel/dma-mapping.c | 3 +++
> arch/ia64/kernel/pci-swiotlb.c | 3 ---
> 2 files changed, 3 insertions(+), 3 deletions(-)
Applied to tip/core/iommu, thanks!
Ingo
next prev parent reply other threads:[~2009-01-27 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 14:43 [PATCH -tip] IA64: fix the compile error on IA64_DIG_VTD FUJITA Tomonori
2009-01-27 14:46 ` Ingo Molnar [this message]
2009-01-27 14:46 ` Ingo Molnar
2009-01-27 17:17 ` Luck, Tony
2009-01-28 1:00 ` FUJITA Tomonori
2009-01-28 1:04 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090127144602.GA12183@elte.hu \
--to=mingo@elte.hu \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox