From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Date: Fri, 06 Feb 2009 15:33:15 +0000 Subject: Re: [linux-next][PATCH] revert headers_check fix: ia64, fpu.h Message-Id: <20090206153315.GD13758@n2100.arm.linux.org.uk> List-Id: References: <20090206164546.6291.KOSAKI.MOTOHIRO@jp.fujitsu.com> <3f9a31f40902060053x18dacf58u40c739ab89f13860@mail.gmail.com> <20090206180957.6294.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20090206145556.GH18368@elte.hu> <1233934141.3209.20.camel@localhost.localdomain> In-Reply-To: <1233934141.3209.20.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Jaswinder Singh Rajput Cc: Ingo Molnar , KOSAKI Motohiro , Jaswinder Singh Rajput , Linus Torvalds , Sam Ravnborg , Andrew Morton , hskinnemoen@atmel.com, cooloney@kernel.org, tony.luck@intel.com, ralf@linux-mips.org, dhowells@redhat.com, matthew@wil.cx, chris@zankel.net, LKML , linux-next , linux-ia64 On Fri, Feb 06, 2009 at 08:59:01PM +0530, Jaswinder Singh Rajput wrote: > On Fri, 2009-02-06 at 15:55 +0100, Ingo Molnar wrote: > > * KOSAKI Motohiro wrote: > > > > > > > Index: b/arch/ia64/include/asm/fpu.h > > > > > =================================> > > > > --- a/arch/ia64/include/asm/fpu.h > > > > > +++ b/arch/ia64/include/asm/fpu.h > > > > > @@ -6,7 +6,7 @@ > > > > > * David Mosberger-Tang > > > > > */ > > > > > > > > > > -#include > > > > > +#include > > > > > > > > > > > > > No , we do not even need asm/types.h > > > > > > > > Subject: [PATCH] Neither asm/types.h nor linux/types.h is not required > > > > for arch/ia64/include/asm/fpu.h > > > > > > > > Signed-off-by: Jaswinder Singh Rajput > > > > > > ok. I confirmed. > > > Tested-by: KOSAKI Motohiro > > > Reviewed-by: KOSAKI Motohiro > > > > Thanks. > > > > Jaswinder, mind adding these tags to the commit and sending a pull request > > with all fixes? > > The following changes since commit 0b86a4e34d885e734a4c4e46293376f3f1c639eb: > Ingo Molnar (1): > Merge branch 'core/header-fixes' of git://git.kernel.org/.../jaswinder/linux-2.6-tip into core/header-fixes > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git core/header-fixes > > Jaswinder Singh Rajput (2): > Neither asm/types.h nor linux/types.h is required for arch/ia64/include/asm/fpu.h > make linux/types.h as assembly safe I continue to disagree with the need for the second patch.