From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Date: Fri, 22 May 2009 10:56:08 +0000 Subject: Re: [PATCH -tip v2 0/5] add common functions for struct dma_map_ops Message-Id: <20090522105608.GM9835@amd.com> List-Id: References: <1242359705-2117-1-git-send-email-fujita.tomonori@lab.ntt.co.jp> <20090522195446L.fujita.tomonori@lab.ntt.co.jp> In-Reply-To: <20090522195446L.fujita.tomonori@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: FUJITA Tomonori Cc: mingo@elte.hu, tony.luck@intel.com, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, arnd@arndb.de On Fri, May 22, 2009 at 07:54:35PM +0900, FUJITA Tomonori wrote: > On Fri, 15 May 2009 12:55:00 +0900 > FUJITA Tomonori wrote: >=20 > > We unified x86 and IA64's handling of multiple dma mapping operations > > (struct dma_map_ops in linux/dma-mapping.h) so we can remove > > duplication in their arch/include/asm/dma-mapping.h. > >=20 > > This patchset adds include/asm-generic/dma-mapping-common.h that > > provides some generic dma mapping function definitions for the users > > of struct dma_map_ops. This enables us to remove about 100 lines. This > > also enables us to easily add CONFIG_DMA_API_DEBUG support, which only > > x86 supports for now. The 4th patch adds CONFIG_DMA_API_DEBUG support > > to IA64 by adding only 8 lines. > >=20 > > This is against tip/master since tip has some changes to > > arch/x86/include/asm/dma-mapping.h. > >=20 > > The changes since the first version are > >=20 > > - fixed a bug that dma_attrs is not passed properly (thanks to Arnd > > Bergmann). > >=20 > > - used a new name, dma-mapping-common.h, instead of dma-mapping.h > > (suggested by Arnd Bergmann). > >=20 > > - added Joerg's Acked-by > >=20 > > > > arch/ia64/Kconfig | 1 + > > arch/ia64/include/asm/dma-mapping.h | 110 ++---------------- > > arch/x86/Kconfig | 1 + > > arch/x86/include/asm/dma-mapping.h | 174 +---------------------= ------ > > include/asm-generic/dma-mapping-common.h | 190 ++++++++++++++++++++++= ++++++++ > > lib/dma-debug.c | 82 ++++++++------ > > 6 files changed, 252 insertions(+), 306 deletions(-) >=20 > Ping, >=20 > Any comments? > I already acked the patches :) Joerg --=20 | Advanced Micro Devices GmbH Operating | Karl-Hammerschmidt-Str. 34, 85609 Dornach bei M=FCnchen System |=20 Research | Gesch=E4ftsf=FChrer: Thomas M. McCoy, Giuliano Meroni Center | Sitz: Dornach, Gemeinde Aschheim, Landkreis M=FCnchen | Registergericht M=FCnchen, HRB Nr. 43632