From: Arnd Bergmann <arnd@arndb.de>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>,
linux-ia64@vger.kernel.org
Subject: Re: [PATCH 2/6] headers_check fix: ia64, fpswa.h
Date: Fri, 05 Jun 2009 09:26:33 +0000 [thread overview]
Message-ID: <200906051026.34046.arnd@arndb.de> (raw)
In-Reply-To: <1244118599.5172.31.camel@ht.satnam>
On Thursday 04 June 2009, Jaswinder Singh Rajput wrote:
> index 62edfce..797b064 100644
> --- a/arch/ia64/include/asm/fpswa.h
> +++ b/arch/ia64/include/asm/fpswa.h
> @@ -68,6 +68,7 @@ typedef struct {
> efi_fpswa_t fpswa;
> } fpswa_interface_t;
>
> +#ifdef __KERNEL__
> extern fpswa_interface_t *fpswa_interface;
> -
> +#endif
> #endif /* _ASM_IA64_FPSWA_H */
It's pretty obvious that the above data structure also doesn't
apply in user space. In fact it looks like the whole file should
just not be exported. Your patch is not helpful there because
it just silences the warning.
Arnd <><
prev parent reply other threads:[~2009-06-05 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1244118232.5172.26.camel@ht.satnam>
[not found] ` <1244118476.5172.29.camel@ht.satnam>
2009-06-04 12:41 ` [PATCH 2/6] headers_check fix: ia64, fpswa.h Jaswinder Singh Rajput
2009-06-04 20:22 ` Sam Ravnborg
2009-06-08 16:33 ` Luck, Tony
2009-06-08 17:48 ` [PATCH] ia64: unexport fpswa.h Sam Ravnborg
2009-06-05 9:26 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906051026.34046.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=jaswinder@kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox