From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frans Pop Date: Fri, 24 Jul 2009 18:23:11 +0000 Subject: Re: [PATCH] ia64: minor Makefile simplification through use =?iso-8859-1?q?of=09cc-ifversion?= Message-Id: <200907242023.12478.elendil@planet.nl> List-Id: References: <200907232056.51064.elendil@planet.nl> <20090723212809.GB9488@merkur.ravnborg.org> <87ws5yoo44.wl%peterc@nicta.com.au> In-Reply-To: <87ws5yoo44.wl%peterc@nicta.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Peter Chubb Cc: Sam Ravnborg , linux-ia64@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org On Friday 24 July 2009, Peter Chubb wrote: > >>>>> "Sam" = Sam Ravnborg writes: > Sam> The above change is correct. But I really wonder if the original > Sam> code was correct? Do we really only want to use the -mtune > Sam> options for this specific gcc version? If this is indeed the > Sam> case this deserves a comment explaning this. > > I suspect it should be all compilers after this one. -mtune=mckinley > didn't work very well in the early gcc 3 compilers and didn't exist in > version 2. How would you like to handle that? As it is essentially a separate issue, my suggestion would be: apply my patch as is and then (if needed) commit a separate patch to fix the incorrect comparisons on top. Cheers, FJP