Re: [RFC Patch 1/2] kexec: show memory info in /proc/iomem

Amerigo Wang
2009-08-12T01:27:13Z

Yu, Fenghua wrote:
>> +
>> +out_free:
>> + kfree(kexec_free_res);
>> + kfree(kexec_res);
>> +out_release:
>> + release_resource(kexec_res);
>> + goto out;
>> }
>>
>
> The order of out_free: and out_release: might be reversed. You need to release_resource first; then kfree. Otherwise the previous failures jump to here and will cause problem.
>

Ahh, sure! I will fix it. Thanks!