public inbox for linux-ia64@vger.kernel.org
 help / color / mirror / Atom feed
From: Fenghua Yu <fenghua.yu@intel.com>
To: linux-ia64@vger.kernel.org
Subject: [PATCH 2.6.30 stable] Bug Fix arch/ia64/kernel/pci-dma.c: fix recursive dma_supported() call in iomm
Date: Sat, 15 Aug 2009 00:33:00 +0000	[thread overview]
Message-ID: <20090815003259.GA18989@linux-os.sc.intel.com> (raw)

The commit 160c1d8e40866edfeae7d68816b7005d70acf391 introduced
dma_ops->dma_supported = iommu_dma_supported;
 
This dma_ops->dma_supported is first called in platform_dma_init() during kernel
boot. Then dma_ops->dma_supported will be called recursively in
iommu_dma_supported.
 
Kernel can not boot because kernel can not get out of iommu_dma_supported until
it runs out of stack memory.

This patch is in commit 51b89f7a6615eca184aa0b85db5781d931e9c8d1

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>

---
 
 arch/ia64/kernel/pci-dma.c |    5 -----
 1 files changed, 5 deletions(-)

diff --git a/arch/ia64/kernel/pci-dma.c b/arch/ia64/kernel/pci-dma.c
index 0569596..f6b1ff0 100644
--- a/arch/ia64/kernel/pci-dma.c
+++ b/arch/ia64/kernel/pci-dma.c
@@ -69,11 +69,6 @@ iommu_dma_init(void)
 
 int iommu_dma_supported(struct device *dev, u64 mask)
 {
-	struct dma_map_ops *ops = platform_dma_get_ops(dev);
-
-	if (ops->dma_supported)
-		return ops->dma_supported(dev, mask);
-
 	/* Copied from i386. Doesn't make much sense, because it will
 	   only work for pci_alloc_coherent.
 	   The caller just has to use GFP_DMA in this case. */

                 reply	other threads:[~2009-08-15  0:33 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090815003259.GA18989@linux-os.sc.intel.com \
    --to=fenghua.yu@intel.com \
    --cc=linux-ia64@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox