From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Date: Thu, 02 Jun 2011 23:03:46 +0000 Subject: Re: [PATCH] Audit: push audit success and retcode into arch ptrace.h Message-Id: <201106030103.46742.richard@nod.at> List-Id: References: <20110602210458.23613.24076.stgit@paris.rdu.redhat.com> <201106030032.17398.richard@nod.at> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable To: Tony Luck Cc: Eric Paris , linux-kernel@vger.kernel.org, fenghua.yu@intel.com, monstr@monstr.eu, ralf@linux-mips.org, benh@kernel.crashing.org, paulus@samba.org, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux390@de.ibm.com, lethal@linux-sh.org, davem@davemloft.net, jdike@addtoit.com, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, viro@zeniv.linux.org.uk, oleg@redhat.com, akpm@linux-foundation.org, linux-ia64@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Am Freitag 03 Juni 2011, 01:00:51 schrieb Tony Luck: > > But there seems to be another problem. > > Why is pt_regs of type void *? > >=20 > > gcc complains: > > In file included from include/linux/fsnotify.h:15:0, > > from include/linux/security.h:26, > > from init/main.c:32: > > include/linux/audit.h: In function =91audit_syscall_exit=92: > > include/linux/audit.h:440:17: warning: dereferencing =91void *=92 point= er > > include/linux/audit.h:440:3: error: invalid use of void expression > > include/linux/audit.h:441:21: warning: dereferencing =91void *=92 point= er > > include/linux/audit.h:441:21: error: void value not ignored as it ought > > to be >=20 > Perhaps same issue on ia64 - but symptoms are different: The void * pointer is the problem. On UML it builds fine when I cast it: #define regs_return_value(r) UPT_SYSCALL_RET((struct uml_pt_regs *)r) I'll test it tomorrow in detail, for now I'm too sleepy. Thanks, //richard