From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Date: Fri, 17 Jun 2011 15:13:12 +0000 Subject: Re: [PATCHv3-resend] atomic: add *_dec_not_zero Message-Id: <201106171713.12983.arnd@arndb.de> List-Id: References: <1306653200-19176-1-git-send-email-sven@narfation.org> <1308307124-15659-1-git-send-email-sven@narfation.org> In-Reply-To: <1308307124-15659-1-git-send-email-sven@narfation.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sven Eckelmann Cc: linux-arch@vger.kernel.org, Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org On Friday 17 June 2011, Sven Eckelmann wrote: > > Introduce an *_dec_not_zero operation. Make this a special case of > *_add_unless because batman-adv uses atomic_dec_not_zero in different > places like re-broadcast queue or aggregation queue management. There > are other non-final patches which may also want to use this macro. > > Reported-by: David S. Miller > Signed-off-by: Sven Eckelmann > Acked-by: Mike Frysinger > Acked-by: James Bottomley > Acked-by: David S. Miller > Acked-by: Ingo Molnar > Acked-by: Jesper Nilsson > Acked-by: Ralf Baechle > Acked-by: David Howells > Acked-by: Chris Metcalf > Acked-by: Geert Uytterhoeven > Acked-by: Will Deacon > Acked-by: Matt Turner > Acked-by: Benjamin Herrenschmidt > Acked-by: Paul Mundt > Acked-by: Heiko Carstens > Acked-by: Hirokazu Takata > Cc: Tony Luck > Cc: Fenghua Yu > Cc: linux-ia64@vger.kernel.org > Cc: Arnd Bergmann > Cc: linux-arch@vger.kernel.org > --- > Nothing changed - only added the Acked-by from Hirokazu Takata. That > means that I am still waiting for ia64 and Arnd Bergmann (maybe he wants > to merge it in his tree?). Hmm, I didn't look at the first versions unfortunately. Remind me why we don't just open-code the atomic_add_unless in batman-adv. Since people apparently think that this patch is a good idea, I'll merge it in the asm-generic tree once I understand why this is done. Arnd