Re: [PATCHv3-resend] atomic: add *_dec_not_zero

[Arnd Bergmann <arnd@arndb.de>]

On Friday 17 June 2011 19:32:57 Sven Eckelmann wrote:
> On Friday 17 June 2011 17:13:12 Arnd Bergmann wrote:
> > On Friday 17 June 2011, Sven Eckelmann wrote:
> > 
> > Hmm, I didn't look at the first versions unfortunately. Remind me why we
> > don't just open-code the atomic_add_unless in batman-adv.
> 
> Because some developers behind batman-adv and fault_inject thought that it is 
> easier readable and David S. Miller said that it is a good idea to have 
> something like it in atomic*.h
> 
> Other places were it can be used:
>  * drivers/media/video/omap3isp/ispstat.c
>  * drivers/s390/net/qeth_core_main.c
>  * fs/ext4/ext4.h
>  * fs/xfs/linux-2.6/xfs_buf.c
>  * mm/memcontrol.c
>  * net/core/drop_monitor.c
>  * net/phonet/pep.c

Ok, sounds good then.

> > Since people apparently think that this patch is a good idea, I'll merge it
> > in the asm-generic tree once I understand why this is done.
> 
> Don't feel pushed --- you can just say that you absolutely doesn't want it. I 
> only tried to keep David happy, but don't want to start a fight over it.

No, it's good, thanks for putting the work into sorting this out! I'll go through
my inbox anyway to see if anything should go into the asm-generic tree for the
next merge window. I think there are a couple of other patches.

	Arnd