From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ralf Baechle Date: Thu, 23 Jun 2011 15:05:57 +0000 Subject: Re: [PATCH] STAGING: Comedi: Build only on arches providing Message-Id: <20110623150557.GA9258@linux-mips.org> List-Id: References: <20110623114536.GA14011@linux-mips.org> <4E032940.5010205@ge.com> <20110623120234.GA22524@linux-mips.org> <8B77EED3-D197-4AB9-9594-278DB7002D6D@kernel.crashing.org> In-Reply-To: <8B77EED3-D197-4AB9-9594-278DB7002D6D@kernel.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kumar Gala Cc: devel@driverdev.osuosl.org, David Howells , linux-m32r@ml.linux-m32r.org, linux-ia64@vger.kernel.org, Paul Mundt , linux-sh@vger.kernel.org, Benjamin Herrenschmidt , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Chris Metcalf , Martyn Welch , Fenghua Yu , "linuxppc-dev@lists.ozlabs.org Tony Luck" , linux-am33-list@redhat.com, Paul Mackerras , linux-m32r-ja@ml.linux-m32r.org, "H. Peter Anvin" , Thomas Gleixner , linux-arch@vger.kernel.org, Ingo Molnar , x86@kernel.org On Thu, Jun 23, 2011 at 07:10:29AM -0500, Kumar Gala wrote: > > (Adding the PPC folks to cc.) > > > > A "git grep -w PAGE_KERNEL_NOCACHE arch/powerpc/" doesn't find anything so > > I don't think the driver will build there. I don't have a PPC toolchain > > to verify that. > > I can verify it fails on PPC as well: > > drivers/staging/comedi/drivers.c: In function 'comedi_buf_alloc': > drivers/staging/comedi/drivers.c:505:37: error: 'PAGE_KERNEL_NOCACHE' undeclared (first use in this function) > drivers/staging/comedi/drivers.c:505:37: note: each undeclared identifier is reported only once for each function it appears in > > However, we do have a #define for PAGE_KERNEL_NC. Do you think this driver in it's current stage is so valuable that some ifdefery to get it to work on PPC is the way to go? IA-64 has PAGE_KERNEL_UC, so basically the same question for IA-64, too. But preferably the driver should be sorted out properly and until the v1 of my patch which disables it on all architectures that don't provide a PAGE_KERNEL_NOCACHE definition will do just fine. Ralf