From: Fengguang Wu <fengguang.wu@intel.com>
To: Dave Airlie <airlied@redhat.com>
Cc: dri-devel@lists.freedesktop.org,
LKML <linux-kernel@vger.kernel.org>,
Ben Skeggs <bskeggs@redhat.com>,
"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>
Subject: Re: [PATCH] nouveau: fix build error on IA64
Date: Wed, 25 Jul 2012 14:36:58 +0000 [thread overview]
Message-ID: <20120725143658.GA1651@localhost> (raw)
In-Reply-To: <20120725080008.GA18012@localhost>
> - select ACPI_WMI if ACPI
> + select ACPI_WMI if ACPI && !IA64
> select MXM_WMI if ACPI
Sorry, the MXM_WMI line should also be changed. Although MXM_WMI
depends on ACPI_WMI, "select" is dumb and will ignore that dependency..
Thanks,
Fengguang
---
From: Fengguang Wu <fengguang.wu@intel.com>
Date: Wed, 25 Jul 2012 15:56:35 +0800
Subject: [PATCH] nouveau: fix build error on IA64
I'm not sure if this is the best way, however it does fix these link
errors on IA64:
ERROR: "wmi_has_guid" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
ERROR: "wmi_evaluate_method" [drivers/gpu/drm/nouveau/nouveau.ko] undefined!
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
drivers/gpu/drm/nouveau/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- linux.orig/drivers/gpu/drm/nouveau/Kconfig 2012-07-25 19:09:37.715358715 +0800
+++ linux/drivers/gpu/drm/nouveau/Kconfig 2012-07-25 22:34:43.775298923 +0800
@@ -11,8 +11,8 @@ config DRM_NOUVEAU
select FRAMEBUFFER_CONSOLE if !EXPERT
select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT
select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT
- select ACPI_WMI if ACPI
- select MXM_WMI if ACPI
+ select ACPI_WMI if ACPI && !IA64
+ select MXM_WMI if ACPI && !IA64
select POWER_SUPPLY
help
Choose this option for open-source nVidia support.
prev parent reply other threads:[~2012-07-25 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 8:00 [PATCH] nouveau: fix build error on IA64 Fengguang Wu
2012-07-25 14:36 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120725143658.GA1651@localhost \
--to=fengguang.wu@intel.com \
--cc=airlied@redhat.com \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).