From: Leif Lindholm <leif.lindholm@linaro.org>
To: Matt Fleming <matt@console-pimps.org>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ia64@vger.kernel.org, matt.fleming@intel.com,
tony.luck@gmail.com, grant.likely@secretlab.ca
Subject: Re: [PATCH v3 2/5] efi: provide a generic efi_config_init()
Date: Thu, 05 Sep 2013 10:23:52 +0000 [thread overview]
Message-ID: <20130905102352.GV18151@rocoto.smurfnet.nu> (raw)
In-Reply-To: <20130902092902.GE28598@console-pimps.org>
On Mon, Sep 02, 2013 at 10:29:02AM +0100, Matt Fleming wrote:
> This patch actually breaks git bisection,
Urgh, sorry about that.
> /home/build/git/efi/arch/x86/platform/efi/efi.c:581:19: error: conflicting types for ‘efi_config_init’
> In file included from /home/build/git/efi/arch/x86/platform/efi/efi.c:33:0:
> /home/build/git/efi/include/linux/efi.h:596:12: note: previous declaration of ‘efi_config_init’ was here
>
> I've merged patches 2,3 and 4 into the following single patch so that
> the ability to bisect isn't lost. Does it look OK? It boots fine on my
> test machines.
Looks fine to me, and works on the ARM port.
I'm about to send out an updated patch set, including this squash.
/
Leif
next prev parent reply other threads:[~2013-09-05 10:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-07 18:54 [PATCH v3 0/5] Make commonly useful UEFI functions common Leif Lindholm
2013-08-07 18:54 ` [PATCH v3 1/5] ia64: add early_memremap() alias for early_ioremap() Leif Lindholm
2013-08-07 18:54 ` [PATCH v3 2/5] efi: provide a generic efi_config_init() Leif Lindholm
2013-09-02 9:29 ` Matt Fleming
2013-09-05 10:23 ` Leif Lindholm [this message]
2013-08-07 18:54 ` [PATCH v3 3/5] efi: x86: use common code for (U)EFI configuration scanning Leif Lindholm
2013-08-07 18:54 ` [PATCH v3 4/5] efi: ia64: " Leif Lindholm
2013-08-07 18:54 ` [PATCH v3 5/5] efi: x86: make efi_lookup_mapped_addr() a common function Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905102352.GV18151@rocoto.smurfnet.nu \
--to=leif.lindholm@linaro.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-efi@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.fleming@intel.com \
--cc=matt@console-pimps.org \
--cc=tony.luck@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox