From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Helgaas Date: Fri, 14 Feb 2014 20:26:43 +0000 Subject: Re: [PATCH v2] Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary prevents Message-Id: <20140214202643.GF31093@google.com> List-Id: References: <20140130000831.GJ16825@google.com> <1391160503-11122-1-git-send-email-linux@eikelenboom.it> <20140203145205.GB2992@phenom.dumpdata.com> <939539486.20140213104824@eikelenboom.it> In-Reply-To: <939539486.20140213104824@eikelenboom.it> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sander Eikelenboom Cc: Konrad Rzeszutek Wilk , Tony Luck , Dave Airlie , Eiichiro Oiwa , Greg Kroah-Hartman , "linux-kernel @ vger . kernel . org" , "linux-pci @ vger . kernel . org" , linux-ia64@vger.kernel.org On Thu, Feb 13, 2014 at 10:48:24AM +0100, Sander Eikelenboom wrote: > Hi Bjorn, > > I have given it another email and another week, but without gaining any reviewed or acked-by's. > It seems the only way forward is to shovel it in linux-next earlier, give it a good soak and see if > anyone starts to squeal .. or that everything seems to be ok :-) > > Would you need a v3 with the acked and reviewed-by from Konrad for x86 in it ? No need, I applied this to my pci/misc branch for v3.15. Tony, let me know if you have any issues with this. Bjorn > Monday, February 3, 2014, 3:52:05 PM, you wrote: > > > On Fri, Jan 31, 2014 at 10:28:22AM +0100, Sander Eikelenboom wrote: > >> Hi Bjorn / Tony, > >> > >> I fixed up ia64 as well and brought it inline again with the x86 code, > >> but i don't have a ia64 machine, so that part is untested. > >> Perhaps Tony is able to review/test it ? > >> > >> Sander > >> > >> > >> > >> Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the primary > >> prevents it from reading it's own rom. It will get the content of the shadowrom > >> at C000 instead, which is of the primary VGA card and the driver of the > >> secondary card will bail out. > >> > >> Fix this by checking if the arch code or vga-arbitration has already > >> determined the vga_default_device, if so only apply the fix to this > >> primary video device and let the comment reflect this. > >> > >> v2: > >> - Fix pci_fixup_video both in x86 and ia64 > >> > >> > >> Sander Eikelenboom (1): > >> Setting the IORESOURCE_ROM_SHADOW flag on a VGA card other than the > >> primary prevents it from reading it's own rom. It will get the > >> content of the shadowrom at C000 instead, which is of the > >> primary VGA card and the driver of the secondary card will bail > >> out. > > > Your editor mutilated your subject line. It ought to have been just > > one line. > > > Anyhow, you can also add 'Reviewed-by: Konrad Rzeszutek Wilk > on the patch for the x86 part. > > > The ia64 "looks" OK to me, but my ia64 box won't boot v3.11 or later > > so I can't give it a 'Tested-by' yet. > > >> > >> arch/ia64/pci/fixup.c | 24 +++++++++++++----------- > >> arch/x86/pci/fixup.c | 18 ++++++++++-------- > >> 2 files changed, 23 insertions(+), 19 deletions(-) > >> > >> -- > >> 1.7.10.4 > >> > >